Maint: Remove potentially extra usage of Unicode.#825
Maint: Remove potentially extra usage of Unicode.#825Carreau wants to merge 2 commits intoipython:mainfrom
Conversation
As far as I can tell setting this to `Unicode` does not achieve much. For example the IPython application that derives from it set it to a plain string and it works. Same for description. From my dev folder I haven't found any usage of name or description that needs this to be a `Unicode`, we we might as well make it always a str, which simplify a bit the codebase/types. Usually the simpler the better. It is _technically_ backward incompatible. See ipython/ipython#13895 that remove the usage of Unicode in description
|
Seems like a reasonable change, but wouldn't this also impact any assignment of Given that this is a breaking change, would this be included in a major release? |
Hum, that's a good question. Either it does not seem to do so, or there is not test for it. No objection to have this wait for a major release if it's breaking. |
|
You are right, if it is not set to Now the main question is do we want name to be settable via the constructor for the default application. And a test need to be added. Good catch. |
Alternative to ipython#825, that adds tests for behavior. I don't think we _need_ the ability to set the value via a constructor, And I'm generally in favor of simplifying, but at least this should have tests.
|
See #826, that adds a test, I'll change that to draft and we can discuss it for next major release. |
Alternative to #825, that adds tests for behavior. I don't think we _need_ the ability to set the value via a constructor, And I'm generally in favor of simplifying, but at least this should have tests.
2 participants
As far as I can tell setting this to
Unicodedoes not achieve much. For example the IPython application that derives from it set it to a plain string and it works.Same for description.
From my dev folder I haven't found any usage of name or description that needs this to be a
Unicode, we we might as well make it always a str, which simplify a bit the codebase/types.Usually the simpler the better.
It is technically backward incompatible.
See ipython/ipython#13895 that remove the usage of Unicode in description