Skip to content

Maint: Remove potentially extra usage of Unicode. #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Carreau wants to merge 2 commits into from
Closed

Maint: Remove potentially extra usage of Unicode. #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d8dc65
Maint: Remove potentially extra usage of Unicode.
Carreau Jan 16, 2023
5be0349
update examples
Carreau Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/subcommands_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def run(self):


class FooApp(Application):
name = Unicode("foo")
name = "foo"
classes = [PrintHello]
aliases = {
"print-name": "PrintHello.greet_name",
Expand All @@ -41,7 +41,7 @@ def start(self):


class BarApp(Application):
name = Unicode("bar")
name = "bar"
classes = [PrintHello]
aliases = {
"print-name": "PrintHello.greet_name",
Expand All @@ -60,8 +60,8 @@ def get_subapp(cls, main_app: Application) -> Application:


class MainApp(Application):
name = Unicode("subcommand-example-app")
description = Unicode("demonstrates app with subcommands")
name = "subcommand-example-app"
description = "demonstrates app with subcommands"
subcommands = {
# Subcommands should be a dictionary mapping from the subcommand name
# to one of the following:
Expand Down
4 changes: 2 additions & 2 deletions traitlets/config/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ class Application(SingletonConfigurable):

# The name of the application, will usually match the name of the command
# line application
name: t.Union[str, Unicode] = Unicode("application")
name: t.Union[str, Unicode] = "application"

# The description of the application that is printed at the beginning
# of the help.
description: t.Union[str, Unicode] = Unicode("This is an application.")
description: str = "This is an application."
# default section descriptions
option_description: t.Union[str, Unicode] = Unicode(option_description)
keyvalue_description: t.Union[str, Unicode] = Unicode(keyvalue_description)
Expand Down