Conversation
modify _make_lslash add .notdef glyph
pelson
left a comment
There was a problem hiding this comment.
Cool! Very exciting! 👍
I think we need to be careful with the pipeline as part 6 in particular tweaks the normal font extensively - those tweaks will want to be different for the mono form.
Perhaps we can use the normal font as the basis for the mono font, swapping in whatever we need to make it look correct? If we take that approach, we simply need to add a stage 9 (or put that at stage 9, and make the final stage work on both). If we can't use the normal font as the basis, then I think we need to be careful to avoid too much branching in pt6 in particular. It maybe that we should have pt6 know that it produces 2 fonts without us passing that as a parameter and calling it twice will at least give us less variance on the "bodyname".
Finally, to proceed, I think we should get to the point where you can submit this without any change to the normal font - that means pulling out whatever we need into a separate PR for the normal font. For the mono, we should have PR which produces suitable samples (Ipsum Lorem if necessary, but perhaps better to have a code snippet or something) so that we can start from the very beginning to have a visible diff as the font evolves.
| ['dflt']]]]]) | ||
| font.addLookupSubtable('ligatures', 'liga') | ||
|
|
||
| c = font.createChar(-1, ".notdef") |
There was a problem hiding this comment.
This looks like a very useful addition even without the mono?
| c.simplify() | ||
| c.round() | ||
|
|
||
| for line, position, bbox, fname, chars in characters: |
There was a problem hiding this comment.
This is for the non-mono form too?
Closes #37
Automatically collects glyphs close to 0.6em in width.
We will continue to consider the choice of glyphs.