MyData API: Return empty result set instead or error - #12256
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
8531689 to
20b796d
Compare
This comment has been minimized.
This comment has been minimized.
20b796d to
0a8a55a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship I'm getting an error in the DataRetrieverApiIT. On line 103 it's finding 0 instead of 1. Also the branch is out of date with dev. |
|
I'm not seeing the error. There is a 4 second sleep that might be too short? I updated the branch and will run it again |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test Results397 tests 382 ✅ 25m 5s ⏱️ Results for commit 824f16f. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
I just tested it locally, when there is an empty result, it returns successfully. When there is not empty result, no message is shown. |
What this PR does / why we need it: SPA needs empty result set instead of error when no results are found
Which issue(s) this PR closes:#11447
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: changelog as this is a breaking change