Skip to content

MyData API: Return empty result set instead or error - #12256

Merged
ChengShi-1 merged 13 commits into
developfrom
11447-mydata-retrieve-empty-result-set
Jun 1, 2026
Merged

MyData API: Return empty result set instead or error#12256
ChengShi-1 merged 13 commits into
developfrom
11447-mydata-retrieve-empty-result-set

Conversation

@stevenwinship

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: SPA needs empty result set instead of error when no results are found

Which issue(s) this PR closes:#11447

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation: changelog as this is a breaking change

@stevenwinship stevenwinship self-assigned this Mar 25, 2026
@github-actions github-actions Bot added GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA These changes are required for the Dataverse SPA SPA.Q2.1 Account Page: My Data Section Type: Bug a defect labels Mar 25, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Mar 25, 2026
@stevenwinship stevenwinship changed the title return empty result set instead or error Return empty result set instead or error Mar 25, 2026
@stevenwinship stevenwinship changed the title Return empty result set instead or error MyData API: Return empty result set instead or error Mar 25, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 26, 2026
@stevenwinship stevenwinship removed their assignment Mar 26, 2026
@github-actions

This comment has been minimized.

@coveralls

coveralls commented Mar 26, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 24.945% (-0.002%) from 24.947% — 11447-mydata-retrieve-empty-result-set into develop

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 11447-mydata-retrieve-empty-result-set branch from 8531689 to 20b796d Compare April 2, 2026 13:36
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 11447-mydata-retrieve-empty-result-set branch from 20b796d to 0a8a55a Compare April 6, 2026 19:36
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) label May 6, 2026
@sekmiller sekmiller self-assigned this May 7, 2026
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project May 7, 2026
@sekmiller

Copy link
Copy Markdown
Contributor

@stevenwinship I'm getting an error in the DataRetrieverApiIT. On line 103 it's finding 0 instead of 1. Also the branch is out of date with dev.

@stevenwinship

Copy link
Copy Markdown
Contributor Author

I'm not seeing the error. There is a 4 second sleep that might be too short?
I can't imagine that 4 seconds would be too short though

I updated the branch and will run it again

@github-actions

This comment has been minimized.

@sekmiller sekmiller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project May 8, 2026
@sekmiller sekmiller removed their assignment May 8, 2026
@cmbz cmbz added the FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) label May 21, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Test Results

397 tests   382 ✅  25m 5s ⏱️
 53 suites   15 💤
 53 files      0 ❌

Results for commit 824f16f.

@github-actions

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11447-mydata-retrieve-empty-result-set
ghcr.io/gdcc/configbaker:11447-mydata-retrieve-empty-result-set

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ChengShi-1 ChengShi-1 self-assigned this Jun 1, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 1, 2026
@ChengShi-1

Copy link
Copy Markdown
Contributor

I just tested it locally, when there is an empty result, it returns successfully.
{"success":true,"message":"Sorry, nothing was found for these roles: Admin, Contributor","data":{"pagination":{"isNecessary":false, ...

When there is not empty result, no message is shown.
{"success":true,"data":{"pagination":{"isNecessary":false,"numResult...

@ChengShi-1
ChengShi-1 merged commit 217d430 into develop Jun 1, 2026
23 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 1, 2026
@ChengShi-1 ChengShi-1 removed their assignment Jun 1, 2026
@stevenwinship
stevenwinship deleted the 11447-mydata-retrieve-empty-result-set branch June 1, 2026 13:58
@pdurbin pdurbin added this to the 6.11 milestone Jun 1, 2026
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q2.1 Account Page: My Data Section SPA These changes are required for the Dataverse SPA Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

MyData API Endpoint - don't return error for empty result set

6 participants