Add migration package for gating runnables behind pre-start migrations - #493
Conversation
Signed-off-by: Andreas Fritzler <andreas.fritzler@sap.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesMigration gating
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to This change gates manager runnables on concurrent startup migrations, but cancellation, partial migration failure, and startup ordering are not fully defined. A canceled migration could block services indefinitely or allow startup after incomplete work, while concurrent failures could leave partial state; these issues should be explicitly addressed or accepted before merging. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed Changes
Add migration package for gating runnables behind pre-start migrations.
Summary by CodeRabbit
New Features
Tests