Replace PropagationPolicy and DeleteAllOf in controller tests - #479
Merged
Conversation
Remove client.PropagationPolicy(metav1.DeletePropagationForeground) and k8sClient.DeleteAllOf from all controller test suites. These do not work reliably in envtest, causing flaky test failures. Replace with scoped cleanup using client.IgnoreNotFound(Delete) and ensure device is always deleted last (after provider verification) so that controllers can finalize child resources properly. Also fix cross-test interference in the VRF test by checking specific provider state instead of global emptiness. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
The test was binding to a hardcoded port (16900) which caused 'address already in use' errors when the previous subtest's server hadn't fully released the port. Use net.ListenPacket on port 0 to get a free port for each subtest. Extract serve method that accepts a net.PacketConn so tests can pass in a pre-bound listener. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
fix/flaky-test
branch
from
August 3, 2026 15:14
c84b14e to
ad9e3fd
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
marked this pull request as ready for review
August 3, 2026 16:51
nikatza
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove client.PropagationPolicy(metav1.DeletePropagationForeground) and k8sClient.DeleteAllOf from all controller test suites. These do not work reliably in envtest, causing flaky test failures.
Replace with scoped cleanup using client.IgnoreNotFound(Delete) and ensure device is always deleted last (after provider verification) so that controllers can finalize child resources properly.
Also fix cross-test interference in the VRF test by checking specific provider state instead of global emptiness.