Skip to content

Create _github-pages-challenge-kellylawrence.json#19914

Merged
orangci merged 2 commits into
is-a-dev:mainfrom
kellylawrence:patch-2
Feb 13, 2025
Merged

Create _github-pages-challenge-kellylawrence.json#19914
orangci merged 2 commits into
is-a-dev:mainfrom
kellylawrence:patch-2

Conversation

@kellylawrence
Copy link
Copy Markdown
Contributor

Create hostname txt file for Github pages verification.

Requirements

  • I have read and understood the Terms of Service.
  • I understand my domain will be removed if I violate the Terms of Service.
  • My file is in the domains directory and has the .json file extension.
  • My file's name is lowercased and alphanumeric.
  • My website is reachable and completed.
  • I have provided sufficient contact information in the owner key.

Website Preview

https://www.kellylawrence.ca

Create hostname txt file for Github pages verification.
@kellylawrence kellylawrence requested a review from a team as a code owner February 13, 2025 15:05
@orangci orangci merged commit 9d468f1 into is-a-dev:main Feb 13, 2025
@kellylawrence
Copy link
Copy Markdown
Contributor Author

kellylawrence commented Feb 14, 2025

@orangci Sorry to bother you, but I'm wondering if the typo change 04c6630 is correct?

The change from _github-pages-challenge-kellylawrence.json to _github-pages-challenge.kellylawrence.json doesn't seem to match the naming convention of the other challenge files from what I can see under the domains folder. Some other examples:

  • _github-pages-challenge-ajtabjs.ajtabs.json
  • _github-pages-challenge-utilsfortheweb.utils.json

Should it should maybe be:

  • _github-pages-challenge-kellylawrence.kelly.json

So _github-pages-challenge-MYUSERNAME.SUBDOMAIN.json with SUBDOMAIN being the kelly.json from my original PR?

I only ask as GitHub still can't seem to verify the domain/find the TXT record and it's been a little over 24 hours now, so I was trying to see what I might have messed up. That's my bad for getting the initial name wrong, after looking over the docs and what the Add A Verified Domain page provides.

@iostpa
Copy link
Copy Markdown
Member

iostpa commented Feb 14, 2025

His typo isn't correct.

Should it should maybe be: _github-pages-challenge-kellylawrence.kelly.json

Yes, it should be that if you own kelly.is-a.dev. You can make a new pull request fixing that.

kellylawrence added a commit to kellylawrence/register that referenced this pull request Feb 14, 2025
Creating properly named `_github-pages-challenge-kellylawrence.kelly.json` file as discussed at is-a-dev#19914 (comment)
kellylawrence added a commit to kellylawrence/register that referenced this pull request Feb 14, 2025
Deleting improperly named `_github-pages-challenge.kellylawrence.json` file as discussed at is-a-dev#19914 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants