Adds prebundle package repointing during installation#4958
Merged
kellyguo11 merged 3 commits intoisaac-sim:developfrom Mar 12, 2026
Merged
Adds prebundle package repointing during installation#4958kellyguo11 merged 3 commits intoisaac-sim:developfrom
kellyguo11 merged 3 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR adds Key issues found during review:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[command_install] --> B[_repoint_prebundle_packages]
B --> C{Isaac Sim path\nfound?}
C -- No --> D[return early]
C -- Yes --> E[Run: site.getsitepackages to get\nsite-packages path]
E --> F{site-packages\ndir exists?}
F -- No --> G[print_warning + return]
F -- Yes --> H[rglob pip_prebundle dirs]
H --> I{Any\npip_prebundle\ndirs?}
I -- No --> J[return early]
I -- Yes --> K[For each prebundle_dir × pkg_name]
K --> L{venv_pkg\nexists?}
L -- No --> K
L -- Yes --> M{prebundled\nexists or is_symlink?}
M -- No --> K
M -- Yes --> N{prebundled\nis_symlink?}
N -- Yes --> O{Already points\nto correct target?}
O -- Yes --> K
O -- No --> P[unlink symlink]
P --> Q[symlink_to venv_pkg]
N -- No --> R[Create .bak backup\ncheck backup.exists\nnot is_symlink ⚠️]
R --> S[rename prebundled → .bak]
S --> Q
Q --> K
K --> T{repointed > 0?}
T -- Yes --> U[print_info count]
T -- No --> V[print_debug up-to-date]
Last reviewed commit: 267adbf |
kellyguo11
approved these changes
Mar 12, 2026
daniela-hase
pushed a commit
to daniela-hase/IsaacLab
that referenced
this pull request
Mar 30, 2026
# Description Isaac Sim ships prebundled copies of packages (torch, warp, newton, etc.) inside `pip_prebundle` directories. Whether Isaac Sim is installed via pip or via a local symlink (`_isaac_sim`), these prebundled copies can shadow the versions installed in the active conda/uv environment (e.g. `torch+cu128` overriding the `torch+cu130` the user installed on aarch64), causing version mismatches or native crashes during Kit startup. This PR adds `_repoint_prebundle_packages()` which runs at the end of `command_install` and replaces prebundled package directories with symlinks pointing to the active environment's `site-packages`. Original copies are preserved as `.bak` for recovery. The operation is idempotent. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Isaac Sim ships prebundled copies of packages (torch, warp, newton, etc.) inside
pip_prebundledirectories. Whether Isaac Sim is installed via pip or via a local symlink (_isaac_sim), these prebundled copies can shadow the versions installed in the active conda/uv environment (e.g.torch+cu128overriding thetorch+cu130the user installed on aarch64), causing version mismatches or native crashes during Kit startup.This PR adds
_repoint_prebundle_packages()which runs at the end ofcommand_installand replaces prebundled package directories with symlinks pointing to the active environment'ssite-packages. Original copies are preserved as.bakfor recovery. The operation is idempotent.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there