Skip to content

Debug CI crash #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvsekkin wants to merge 2 commits into from
+5 −0
Closed

Debug CI crash #5621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76a5c07
Add PYTHONFAULTHANDLER
nvsekkin May 14, 2026
39a7a1e
Isolate failing test
nvsekkin May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/run-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ runs:
-e ISAAC_SIM_HEADLESS=1 \
-e ISAAC_SIM_LOW_MEMORY=1 \
-e PYTHONUNBUFFERED=1 \
-e PYTHONFAULTHANDLER=1 \
-e PYTHONIOENCODING=utf-8 \
-e GITHUB_ACTIONS=${GITHUB_ACTIONS:-} \
-e TEST_RESULT_FILE=$result_file"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ jobs:
filter-pattern: "not isaaclab_"
shard-index: "1"
shard-count: "3"
# TEMP: Single test for SIGSEGV repro
include-files: "test_sensor_base.py"
container-name: isaac-lab-core-2-test

test-isaaclab-core-3:
Expand Down
2 changes: 2 additions & 0 deletions tools/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,8 @@ def run_individual_tests(test_files, workspace_root, isaacsim_ci):
sys.executable,
"-m",
"pytest",
"-s",
"-vv",
Comment on lines +344 to +345
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unbounded memory growth with -s flag

-s disables pytest's internal output capture so all test stdout flows directly into the subprocess pipe. capture_test_output_with_timeout accumulates the entire pipe content in memory (stdout_data += chunk). Isaac Sim tests are extremely verbose — simulation logs, Kit messages, shader compilation output — and the -s flag means none of that is buffered or discarded by pytest. On a long-running test, stdout_data can grow to hundreds of MB inside the conftest runner process, which could trigger an OOM kill of the runner itself rather than the test under investigation.

Comment on lines +344 to +345
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Debug flags appear intended as temporary but have no revert marker

-s and -vv are diagnostic flags that significantly increase log volume and are typically added temporarily while investigating a specific crash. There is no comment in the code or the PR description linking these to a follow-up issue or indicating they are intended to be permanent. If these land on develop without a revert plan, every subsequent CI run will produce substantially larger logs, which can make it harder to find signal in the output once the crash is resolved.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"--no-header",
f"--config-file={workspace_root}/pyproject.toml",
f"--junitxml=tests/test-reports-{str(file_name)}.xml",
Expand Down
Loading