Removed OVRTX 0.2.x compatibility code paths#5778
Conversation
…v.renderers.OVRTXRenderer`.
~isaaclab_ov.renderers.OVRTXRendererThere was a problem hiding this comment.
Good cleanup removing OVRTX 0.2.x compatibility code. The simplification of the codebase by removing version checks, fallback paths, and the _usd_handles tracking mechanism is welcome.
I noticed one issue to address:
Update (ea9f0d8):
✅ Both issues from my previous review have been addressed:
- Legacy kernels removed from
ovrtx_renderer_kernels.py - Exception handling added around
reset_stage()
LGTM
Update (26b6953):
Reviewed additional test cleanup: removed legacy kernel test classes (TestExtractAllDepthTilesKernelLegacy, TestRandomColorsFromIdsKernelLegacy) and associated imports/references. Clean test maintenance aligning with kernel removals.
✅ No issues found in the incremental changes.
Update (cc7b3d1):
Minor changelog wording refinement: "compatibility code paths" → "legacy OVRTX 0.2.x code paths". No functional changes.
✅ No issues.
Greptile SummaryThis PR removes all OVRTX 0.2.x compatibility code paths from
Confidence Score: 4/5Safe to merge; the cleanup is mechanical and the logic is straightforward, with one minor gap in error handling during teardown. The reset_stage() call in cleanup() is now unguarded: if it throws, self._renderer is never nulled out, leaving the renderer in a partially torn-down state on any subsequent cleanup attempt. The previous remove_usd loop wrapped each call in a try/except so teardown always completed. All other removals are clean and correct. The cleanup method in ovrtx_renderer.py deserves a second look for the missing exception guard around reset_stage(). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[OVRTXRenderer.__init__] --> B[create_render_data]
B --> C{_initialized_scene?}
C -- No --> D[_initialize_from_spec]
D --> E[build_render_product_as_string]
E --> F[Combine exported USD + render product string]
F --> G{temp_usd_dir set?}
G -- Yes --> H[Write combined USD to file for debugging]
H --> I[open_usd_from_string]
G -- No --> I
I --> J{use_ovrtx_cloning?}
J -- Yes --> K[_clone_environments_in_ovrtx + _update_scene_partitions_after_clone]
K --> L[bind_attribute cameras + objects]
J -- No --> L
L --> M[render loop: update_camera to step to _process_render_frame]
M --> N[cleanup: unbind to reset_stage]
Reviews (1): Last reviewed commit: "Removed OVRTX 0.2.x compatibility code p..." | Re-trigger Greptile |
Description
Removed OVRTX 0.2.x compatibility code paths from :class:
~isaaclab_ov.renderers.OVRTXRenderer.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there