Skip to content

858 - Failed SyncMailjetUsersJob #858#414

Merged
mariusmarin-dev merged 2 commits into
mainfrom
858_mail_jet
May 20, 2026
Merged

858 - Failed SyncMailjetUsersJob #858#414
mariusmarin-dev merged 2 commits into
mainfrom
858_mail_jet

Conversation

@mariusmarin-dev
Copy link
Copy Markdown

No description provided.

Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/ExternalAccountManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/test/java/uk/ac/cam/cl/dtg/segue/api/managers/UserManagerTest.java Dismissed
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAuthenticationManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/api/managers/GameManager.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/QuestionFacade.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/RequestLoggingFilter.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/api/RequestLoggingFilter.java Fixed
Comment thread src/main/java/uk/ac/cam/cl/dtg/isaac/configuration/IsaacApplicationRegister.java Outdated
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java
Comment thread src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java
}
} catch (Exception e) {
log.error("Unexpected error while processing file {}: {}", treeWalk.getPathString(), e.getMessage(), e);
log.error(CONTENT_LOG_PREFIX + "Unexpected error while processing file {}: {}", treeWalk.getPathString(), e.getMessage(), e);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 131).

- Implement Mailjet bulk sync with job tracking and error recovery
- Add rate limit handling: fail fast on repeated rate limits during polling
- Add sync result reporting: email admins only on failures
- Fix OAuth2 CSRF check: add session fallback when cookie missing
- Fix CorsFilter: prevent duplicate CORS headers on OPTIONS responses
- Fix ContentIndexer null checks: getChildren() and IsaacCardDeck.getCards()
- Add CONTENT prefix logging throughout ContentIndexer for observability
- Fix GameManager unsafe cast (ClassCastException on GET /random)
- Fix CodeQL finding: ensure CSRF cookies are always Secure
- Fix various test mocks for session getId() and getAttribute()

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

@mariusmarin-dev mariusmarin-dev merged commit 70a7da0 into main May 20, 2026
7 of 8 checks passed
@mariusmarin-dev mariusmarin-dev deleted the 858_mail_jet branch May 20, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants