Breadcrumbs should show the page title, not a guess from the filename - #67
Merged
Conversation
The last crumb was built from the filename run through humanize, which title-cased it and dropped punctuation. pi-terminal-kit rendered as "Pi terminal kit" and blog posts lost their apostrophes. LinkTitle uses the title the page declares, so the crumb now matches the heading on the page. Also removes two unused variables at the top of the partial.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last breadcrumb was derived from the filename run through
humanize, so it title-cased everything and threw away the title the page actually declares./projects/pi-terminal-kit//blog/git-wasnt-built-for-agents/The blog case is the one I did not expect: humanizing a slug cannot recover punctuation, so every post title silently lost its apostrophes in the trail.
LinkTitlefalls back toTitle, so the crumb now matches the heading on the page.Also deletes two variables at the top of the partial that were computed and never used.
Verified with
hugo --gc --minify, zero errors and zero warnings, and by reading the rendered breadcrumb out of three built pages including a section index.This PR doubles as the first real use of the preview pipeline, so the rendered result should be visible at the preview URL below.