Update Elasticsearch handling of schools list - #786
Merged
Conversation
This is no longer used anywhere now that the school list reader uses a BooleanInstruction
The new schoolId fieldname contains a capital letter, so capitalisation matters where it didn't before. The raw fields suffix also breaks things for some reason, and since this is an exact match query anyway we don't need to explicitly disable things like stemming, so it should be safe to remove the suffix.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 41.00% 41.00% -0.01%
==========================================
Files 550 550
Lines 23581 23602 +21
Branches 2843 2848 +5
==========================================
+ Hits 9670 9678 +8
- Misses 13039 13052 +13
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Integrates removal of admin user postcode search & migration to our newer ES framework into the school list changes.
Since we are now using a MatchInstruction here, and school ID is no longer indexed as a raw field, there should no longer be any processing done on the school ID fieldname here.
This prints lots of warnings when running ETL, and isn't useful.
axlewin
marked this pull request as ready for review
August 12, 2026 10:59
We obviously need to match exactly when searching by ID, but I think we should also only match exactly when querying here too, to avoid loose matches affecting the score of results.
jsharkey13
approved these changes
Aug 13, 2026
Since we have the old and new APIs running simultaneously, we can't afford to expunge the old school list index without bringing the old API offline - otherwise it will fail when it tries to read the school data. So create a new index name (and unique alias names!) for the new format data, so both can coexist.
jsharkey13
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.