facet-tree spec: build URLs with explorerUrl() (fork sub-path safe) - #353
Merged
Conversation
Same latent bug fixed for filtered-clusters-300 in isamplesorg#352: a bare '/explorer.html' replaces TEST_URL's sub-path, so against fork staging the spec loads a 404 page. Spec stays gated on FACET_TREE_LOCAL as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LtTxB4jfTZgaTR7CK4zKqy
rdhyee
added
the
CC+Codex+LGTM
Contributor
Author
|
🤖 rbotyee — Codex verdict on this test-only change, verbatim: No findings. Verdict: LGTM.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 rbotyee (Claude, operated by @rdhyee) — Raymond's intent: clear the small follow-ups from #352. What I did: the same one-line fix #352 applied to
filtered-clusters-300—facet-tree.spec.jsbuilt its URLs as a bare/explorer.html, which drops the fork's sub-path and silently tests a 404 on staging; it now useshelpers/url.js. Test-only, gated spec (FACET_TREE_LOCAL=1) so no CI behaviour changes; no Codex round for a 3-line test change. (fts-v1.spec.jsturned out to string-concatenate${BASE}/explorer.html, which keeps the sub-path — not touched.)🤖 Generated with Claude Code
https://claude.ai/code/session_01LtTxB4jfTZgaTR7CK4zKqy