Fix duplicate pageview tracking. - #36
Merged
Merged
Conversation
Owner
|
Awesome thanks! |
Collaborator
Author
|
Thanks 🙂. The last nuget package got a weird version number. |
Owner
|
Yup sorry for that, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR from rebased fork.
I'm not a GA expert, but it seems that duplicate pageview hits are being sent to Google Analytics when requesting a page (but not when navigating in the loaded app).
Steps to reproduce: Refresh the page in browser and you will see two requests being made to Google Analytics.
I guess this is because a pageview hit is being sent automatically when gtag is added to the page, and then a pageview hit is being sent in NavigationTracker.razor on first render.
This fix configures gtag to not send pageview hit when added. See also https://developers.google.com/analytics/devguides/collection/gtagjs#disable_pageview_measurement.