(InSAR) Replace en dash (U+2013) with ASCII hyphen in HDF5 descriptions#292
Merged
nemo794 merged 1 commit intoJun 18, 2026
Merged
Conversation
…riptions Replaced Unicode en dash character (U+2013 "–") with standard ASCII hyphen (U+002d "-") in 19 locations across 4 Python files. The en dash was causing display issues in some programs, appearing as "â€"" instead of "–". Files modified: - python/packages/isce3/signal/rfi_freq_null.py (1 occurrence in citation) - python/packages/nisar/products/insar/GUNW_writer.py (5 occurrences in mask descriptions) - python/packages/nisar/products/insar/GOFF_writer.py (4 occurrences in mask descriptions) - python/packages/nisar/products/insar/InSAR_L1_writer.py (9 occurrences in mask descriptions) This fix ensures HDF5 attribute descriptions display correctly across all programs and avoids confusion with special Unicode characters in source code.
xhuang-jpl
approved these changes
Jun 16, 2026
xhuang-jpl
left a comment
xhuang-jpl
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you @nemo794 for the checking, I will open a PR to fix the InSAR part.
oberonia78
approved these changes
Jun 18, 2026
oberonia78
left a comment
oberonia78
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @nemo794
Contributor
Author
|
Thank you @xhuang-jpl and @oberonia78 ! |
Contributor
Author
|
Note: For documentation purposes, this change has been reflected in the corresponding XML specs, here: https://github-fn.jpl.nasa.gov/NISAR-ADT/NISAR_PIX/pull/358 |
Tyler-g-hudson
added a commit
that referenced
this pull request
Jun 25, 2026
commit 0e1f80c Author: xhuang-jpl <118782850+xhuang-jpl@users.noreply.github.com> Date: Wed Jun 24 16:38:22 2026 -0700 Fix the Ampcor issues from Lijun's branch and increase the limit of the search radius (#282) * sm r3.4 * change the SM commit id for R4.0.2 * remove the mask description for the wrapped ifgram * remove the tmp folder * fix minors * comment out the checkPixelInImageRange * pycuampcor: fix the pixels out of range issue * pycuampcor: fix an error in determining the corrwindow size * update the maximum search radius to be 256 --------- Co-authored-by: Xiaodong Huang <xhuang@nisar-adt-dev-3.jpl.nasa.gov> Co-authored-by: Lijun Zhu <ljzhu@gps.caltech.edu> commit 813d729 Author: Brian Hawkins <1729052+bhawkins@users.noreply.github.com> Date: Wed Jun 24 13:56:09 2026 -0500 Handle case where no samples in a rangline are valid (#327) * Handle case where all subswaths are invalid. * Log some details about missing data. * Fix typo * Use signed integer for negative values... commit 075795f Author: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Date: Thu Jun 18 15:59:58 2026 -0700 Fix STATIC filenames with fractional posting by rounding posting after converting to decimeters. (#314) * disable polarimetric symmetrization by default * revert changes to `symmetrize_cross_pol_channels` * Update GCOV and GSLC specification XMLs * Revert changes to the GCOV and GSLC specification XMLs * round posting after conversion to decimeters commit 3f7027d Author: SamNemo <11642807+nemo794@users.noreply.github.com> Date: Thu Jun 18 10:29:43 2026 -0700 Fix text encoding: Replace en dash (U+2013) with ASCII hyphen in descriptions (#292) Replaced Unicode en dash character (U+2013 "–") with standard ASCII hyphen (U+002d "-") in 19 locations across 4 Python files. The en dash was causing display issues in some programs, appearing as "â€"" instead of "–". Files modified: - python/packages/isce3/signal/rfi_freq_null.py (1 occurrence in citation) - python/packages/nisar/products/insar/GUNW_writer.py (5 occurrences in mask descriptions) - python/packages/nisar/products/insar/GOFF_writer.py (4 occurrences in mask descriptions) - python/packages/nisar/products/insar/InSAR_L1_writer.py (9 occurrences in mask descriptions) This fix ensures HDF5 attribute descriptions display correctly across all programs and avoids confusion with special Unicode characters in source code. Co-authored-by: Samantha C. Niemoeller <samantha.c.niemoeller@jpl.nasa.gov> commit db4f65b Author: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Date: Wed Jun 17 14:59:11 2026 -0700 Add margins to the STATIC product Doppler LUT grid boundaries to ensure full radargrid coverage. (#298) * disable polarimetric symmetrization by default * revert changes to `symmetrize_cross_pol_channels` * Update GCOV and GSLC specification XMLs * Revert changes to the GCOV and GSLC specification XMLs * Add margins to the Doppler LUT grid boundaries to ensure full radargrid coverage. * Add margins to the Doppler LUT grid boundaries to ensure full radargrid coverage. * Add margins to the Doppler LUT grid boundaries to ensure full radargrid coverage. commit 67f0878 Author: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Date: Mon Jun 8 11:43:17 2026 -0700 Improve DEM bounding box selection when product coordinates are in a different projection than the DEM (#275) * disable polarimetric symmetrization by default * revert changes to `symmetrize_cross_pol_channels` * Update GCOV and GSLC specification XMLs * Revert changes to the GCOV and GSLC specification XMLs * Update DEM bounding box selection * Improve variable names, docstrings, and handle incorrect starting/ending ordering * Improve variable names * Ensure latitude values remain within [-90, 90] * Ensure latitude values remain within [-90, 90] * Simplify code * Use parenthesis to make it clear evaluation order * improve comments * revert changes to constructor of variables `all_x` and `all_y` * change margin types from `float` to `double`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced Unicode en dash character (U+2013 "–") with standard ASCII hyphen (U+002d "-") in 19 locations across 4 Python files. The en dash was causing display issues in some programs, appearing as "â€"" instead of "–".
This issue is not readily visible to the human eye in all programs; for example, the en dash renders nicely in HDFView.
However, the issue does appear in e.g. H5Web extension for VSCode:
This fix ensures HDF5 attribute descriptions display correctly across all programs and avoids confusion with special Unicode characters in source code.
NOTE: If this PR is approved, this change will need to be reflected in the PIX Product Specs as well. Currently, the product specs also use a Unicode en dash.
cc: @hfattahi