Release [isisbusapps/request-consumables - 1.3.0] to production - #428
Merged
Conversation
William-Edwards-STFC
approved these changes
Sep 2, 2026
William-Edwards-STFC
left a comment
William-Edwards-STFC
left a comment
Member
There was a problem hiding this comment.
Weird that this didn't use the version tag and used the sha one instead
Consolidates the now shared config into base. The only change to the generated dev yaml is volume ordering.
Contributor
|
Looks like that part of the job is using double square bracket bash syntax in a non-bash environment. The action run was https://github.com/isisbusapps/request-consumables/actions/runs/33634010450/job/100260489732, and As a little test: me@pc:~$ sh
$ if [[ -n "asdf" ]]; then echo "pass"; else echo "fail"; fi
sh: 1: [[: not found
fail
$ bash
me@pc:~$ if [[ -n "asdf" ]]; then echo "pass"; else echo "fail"; fi
pass |
William-Edwards-STFC
approved these changes
Sep 3, 2026
ACLay
requested review from
a team and
TCMeldrum
and removed request for
a team
September 3, 2026 10:03
TCMeldrum
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Deployment PR
Details
isisbusapps/request-consumables1.3.0Review Checklist
Merging this PR will trigger ArgoCD to sync the new image.