Skip to content

fix(webview): open terminal file links in editor - #47

Merged
islee23520 merged 1 commit into
mainfrom
fix/file-link-open-routing
Jun 1, 2026
Merged

fix(webview): open terminal file links in editor#47
islee23520 merged 1 commit into
mainfrom
fix/file-link-open-routing

Conversation

@islee23520

Copy link
Copy Markdown
Owner

Summary

  • parse terminal file references including @src/foo.ts:12:3, src/foo.ts, src/foo.ts:12, README.md#L10, and file:///... paths
  • route file link activation through the existing openFile webview message
  • extract host-side open-file handling and reject invalid line/column and non-file URL payloads before touching the editor

ULW plan

Verification

  • RED: npm run test -- src/webview/links/index.test.ts src/providers/MessageRouter.test.ts src/types.test.ts failed before implementation for at-prefixed path suffix parsing, file URI suffix parsing, and invalid openFile location guards
  • GREEN: npm run test -- src/webview/links/index.test.ts src/providers/MessageRouter.test.ts src/types.test.ts (74 tests)
  • GREEN: npm run compile
  • GREEN: npm run lint -- src/webview/links/index.ts src/webview/links/index.test.ts src/providers/openFile.ts src/providers/MessageRouter.ts src/providers/MessageRouter.test.ts src/types.ts src/types.test.ts
  • GREEN: npm run compile:e2e
  • GREEN: git diff --check origin/main...HEAD
  • Manual QA channel: tmux-run targeted file-link/openFile tests passed (QA_DONE:0)

Note

MessageRouter.ts is still larger than ideal, but this change extracts open-file behavior to src/providers/openFile.ts instead of adding more logic to the router.

Comment thread src/webview/links/index.ts Fixed
@islee23520
islee23520 force-pushed the fix/file-link-open-routing branch from 3c9a3ca to 58cdcb9 Compare June 1, 2026 11:14
@islee23520
islee23520 merged commit 28da0ac into main Jun 1, 2026
4 checks passed
@islee23520
islee23520 deleted the fix/file-link-open-routing branch June 1, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants