fix: on-start/status honor the git-repo gate - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
CODE_TRACE_REQUIRE_GIT_REPOis on (the default), the Stop hook correctly refuses to trace outside a git repo. But the SessionStart reminder andcode-trace statusignored the gate and still told the user "tracing ENABLED" — false reassurance in exactly the places the gate exists for.Fix
on_start(): printstracing inactive (not in a git repository)when the gate blocks tracing.status(): same check, same wording.Tests
on_start_reports_inactive_outside_git_repoon_start_reports_enabled_inside_git_repoTestEnvincli_test.rswithwith_env()so individual tests can re-enable the gate.All 186 tests pass.