Replace all new line characters in flash message

[qzminski]

A colleague of mine just encountered a problem where the JS failed because not all new line characters were replaced. I think to fix this the following change has to be made:

if ($messages !== '') {
    $template->hasMessages = true;
-    $template->messages = str_replace(array("\n", "'"), array('', '\''), $messages);
+    $template->messages = str_replace(array("\n", "\r", "'"), array('', '', '\''), $messages);
}

https://github.com/isotope/core/blob/master/system/modules/isotope/library/Isotope/Frontend.php#L337

What do you think?

[aschempp]

Who added newline characters to the message in the first place? Shouldn't it be fixed there?

[qzminski]

That's a parsed frontend template being displayed there.

[aschempp]

😮 why would a template be in the flash messages?

[qzminski]

It has been there ever since:

• core/system/modules/isotope/library/Isotope/Message.php

  Line 103 in 9c59472

  $objModule->type = 'iso_messages';

• https://github.com/isotope/core/blob/master/system/modules/isotope/library/Isotope/Module/Messages.php#L59
• https://github.com/isotope/core/blob/master/system/modules/isotope/templates/modules/mod_iso_messages.html5