Skip to content

Fix SSR by checking browser environment#474

Merged
dej611 merged 1 commit intomasterfrom
fix/ssr
Jan 13, 2020
Merged

Fix SSR by checking browser environment#474
dej611 merged 1 commit intomasterfrom
fix/ssr

Conversation

@dej611
Copy link
Copy Markdown
Member

@dej611 dej611 commented Jan 13, 2020

Fixes #473

PR Checklist

  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Skip the font loading check on non-browser environments for SSR builds.

Changes proposed in this pull request:

  • Check window environment

@dej611 dej611 merged commit 97441aa into master Jan 13, 2020
@dej611 dej611 deleted the fix/ssr branch January 13, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanyamdogra sanyamdogra Awaiting requested review from sanyamdogra

1 more reviewer

@francescozaia francescozaia francescozaia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] WebFont loader code is preventing SSR builds

2 participants

@dej611 @francescozaia