Fix Safari Icon issue with SVG rendering#657
Merged
Conversation
emilioSp
approved these changes
Jan 12, 2021
Collaborator
emilioSp
left a comment
emilioSp
left a comment
There was a problem hiding this comment.
LGTM.
I've also tested it with Safari on https://github.com/italia/api-oas-checker
Thanks, @dej611
Member
sebbalex
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #654
This PR addresses the bug with Safari and SVG icons from the BI sprite asset.
The Icon pipeline has been rewritten to use the SVGR tool to automatically generate a JSX component for each raw SVG icon in the BI tool.
build:svgnpm script)It would be nice to have something like Browserstack tests for this to test. I've locally tested it with a Gatsby instance, but having a CI check would be even better.
PR Checklist
masterbranch.