WIP Toolbar component and documentantion

[va-deem]

Fixes #

PR Checklist

• My branch is up-to-date with the Upstream master branch.
• The unit tests pass locally with my changes (if applicable).
• I have added tests that prove my fix is effective or that my feature works (if applicable).
• I have added necessary documentation (if appropriate).

Short description of what this resolves:

This is PR to add Toolbar component

Changes proposed in this Pull Request:

• feat: adding toolbar component

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/design-react-kit/H44trU3V3vdmj7QaNXubp5iNia8r
✅ Preview: https://design-react-kit-git-fork-va-ce96ef-dip-trasformazione-digitale.vercel.app

[va-deem]

Hello! I'd like to try to complete this task. I've opened a PR where I added basic component (in 3 sizes) and documentation. Please check if I'm doing right (this is the first time I doing that kind of stuff) and I will continue with it.
Thanks

[dej611]

🎉 Thanks for your contribution!

This is already a great start! I've left some comments about improvements that can be done on the current codebase.
Do you mind add also add a ToolbarDividerItem component?

[dej611]

To be honest I feel this one should come from the Toolbar context rather than as a prop. I cannot find an instance of icon-sm outside the small version of the toolbar. But do not worry for now, will think about it later.

[va-deem]

Yes I feel so. If we add class 'toolbar-small' to Toolbar component, icons in ToolbarItem should be small too. That was my first intention but I couldn't find the way to do it for now.

[dej611]

Don’t worry for now, it can be a follow up of this PR

[dej611]

Meanwhile, can you remove it and set it to false internally where used?

[va-deem]

Removed, but now the ToolbarItem component lacks the 'small' size. In the EsempioSmall the icons are exactly the same size as they are in Esempio or EsempioMedium.

[va-deem]

tada Thanks for your contribution!

This is already a great start! I've left some comments about improvements that can be done on the current codebase. Do you mind add also add a ToolbarDividerItem component?

Thanks, that was my first commit to open source. :) I don't mind to add ToolbarDividerItem, of course.
I've added some tests to both components.
Will continue with them

[dej611]

Checked the CI error and it’s just new snapshots not been added.

You can do this on your machine and upload the new file:

yarn test -u

That should fix it

[dej611]

The PR looks good. 🚀

If you can address only last few feedback I'd say it's ready to merge 👍

[dej611]

Meanwhile, can you remove it and set it to false internally where used?

[va-deem]

Checked the CI error and it’s just new snapshots not been added.

You can do this on your machine and upload the new file:

yarn test -u

That should fix it

I would suggest adding it to the 'How to contribute' section as a necessary step

[dej611]

All good! 🎉

Thanks for your contribution!