plot: update some output strings #3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
+ Coverage 90.58% 90.65% +0.06%
==========================================
Files 158 158
Lines 10572 10572
==========================================
+ Hits 9577 9584 +7
+ Misses 995 988 -7
Continue to review full report at Codecov.
|
Contributor
Author
|
Only Py36 on Linux build failed (https://travis-ci.com/github/iterative/dvc/builds/164523499). Looks like a glitch? |
jorgeorpinel
changed the title
3 tasks
jorgeorpinel
changed the title
Closed
pared
suggested changes
May 11, 2020
Contributor
pared
left a comment
pared
left a comment
There was a problem hiding this comment.
One comment, besides that LGTM.
Contributor
Author
|
Fixed your comment, @pared. I also made a few more changes to match the now published version in https://dvc.org/doc/command-reference/plot/diff as well as a few more small upcoming changes in treeverse/dvc.org/pull/1283. PTAL |
pared
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
β I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. π