test: apply production-parity Elasticsearch mappings in the test harness#35
Merged
Conversation
The fixture loader created indexes with no mappings, so Elasticsearch dynamic mapping (analysed text + .keyword subfields) drove filter behaviour. Production indexes (event-database-imports) use `dynamic: strict` with explicit types and no normalizer, so several filter tests passed for semantics production does not have — most starkly tag filtering (`?tags=itkdev` matched under dynamic mapping but `tags` is an exact, case-sensitive `keyword` in production). - Add production-parity mappings at tests/resources/mappings/*.json (dynamic: strict), hand-kept copies of the importer's src/Model/Indexing/Mappings. - FixtureLoader::createIndex() applies the mapping and fails loudly if missing; drop the now-obsolete `ignore_error` from the fixture Taskfile targets. - Reconcile the tag filter expectations to keyword semantics (ITKDev→2, itkdev→0, for-boern→1 whole-value, boern→0); only these cases needed changing — the rest of the suite was already production-accurate. - Index-contract Stop hook now also watches tests/resources/mappings/; the filter-provider-reviewer brief checks the mapped field type.
|
✅ No changes detected in API specification |
…appings # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test harness created Elasticsearch indexes with no mappings, so Elasticsearch dynamic mapping (analysed
text+.keywordsubfields) silently drove filter behaviour. Production indexes (created byevent-database-imports) usedynamic: strictwith explicit per-field types and no normalizer. As a result several filter tests were green for semantics production does not have — most starkly tag filtering:?tags=itkdevmatched under dynamic mapping, buttagsis an exact, case-sensitivekeywordin production (fixtures store"ITKDev").Changes
tests/resources/mappings/*.json— production-parity mappings (dynamic: strict), hand-kept copies of the importer'ssrc/Model/Indexing/Mappings/*, covering all 7 indexes.src/Fixtures/FixtureLoader.php—createIndex()applies the mapping for the index and fails loudly if the mapping file is missing (never silently creates a dynamic index). Injected$mappingsDirviaconfig/services.yaml.Taskfile.yml— droppedignore_error: truefrom the fixture targets (theentityIdwarning it masked is already gone), so fixture-load failures now surface.EventsFilterTest/OccurrencesFilterTest/DailyOccurrencesFilterTest:ITKDev→2,itkdev→0 (case-sensitive),aros→3,for-boern→1 (whole-value, not substring),boern→0. The two@todoblocks guessing at "contains-word" tag behaviour are deleted — this is their answer. Only the tag cases needed changing; every other filter/contract/pagination test was already production-accurate.Stophook now also watchestests/resources/mappings/; thefilter-provider-reviewerbrief checks the mapped field type (keyword= exact,text= tokenised).Verification
dynamic: strict; a doc with an unmapped field is rejected (strict_dynamic_mapping_exception, verified against a throwaway index).task fixtures:load:test --yes+task api:test→ 166 tests, 447 assertions, 4 skipped (the pre-existingFilterErrorTestskips). php-cs-fixer, PHPStan level 8, and prettier/markdownlint all clean.CollectionContractTest/ItemContractTestunchanged (raw_sourcepassthrough — a control group proving the harness change altered query semantics only).Note
Tag matching is now pinned as exact, case-sensitive (production reality). If case-insensitive tag search is the desired product contract, that is a
lowercasenormalizer on the keyword mappings inevent-database-imports(plus a reindex), not a change here.