Skip to content

Update f90wrap path for libneo vmec_support decomposition#336

Merged
krystophny merged 1 commit into
mainfrom
dep-audit/decompose-neo-core
Jun 6, 2026
Merged

Update f90wrap path for libneo vmec_support decomposition#336
krystophny merged 1 commit into
mainfrom
dep-audit/decompose-neo-core

Conversation

@krystophny
Copy link
Copy Markdown
Member

@krystophny krystophny commented Apr 9, 2026

Risk tier

  • T0: docs, comments, small build metadata
  • T1: pure refactor, no behavior change intended
  • T2: local numerical logic
  • T3: physics, output behavior, coordinate convention
  • T4: parallelism, GPU, dependency, CI, or security-sensitive build logic

Correctness contract

Intended behavior change

Update the f90wrap source path for canonical_coordinates_mod.f90 to the decomposed libneo VMEC-support layout: src/vmec_support/canonical_coordinates_mod.f90.

Behavior that must not change

SIMPLE Python wrapping should still include the same canonical-coordinate module when built against the matching decomposed libneo branch.

Coordinate / unit conventions

Unchanged.

Numerical invariants

Unchanged. This is a dependency-layout change only.

Tests added

  • unit: none
  • integration: existing build should validate against matching libneo branch
  • system: none
  • golden record: unchanged

Golden-record impact

  • unchanged
  • changed

Failure modes considered

  • Building against old libneo fails because the moved file path does not exist.
  • Building against decomposed libneo should find the new path.
  • This PR should stay draft until the matching libneo branch/tag is selected in CI.

Manual validation

Local rebase succeeded. Local build against the current local libneo checkout failed as expected for this draft because that checkout does not contain the decomposed src/vmec_support path.

Verification

make test-nopy TEST=test_boozer_chartmap VERBOSE=1
...
ninja: error: '/home/ert/code/libneo/src/vmec_support/canonical_coordinates_mod.f90', needed by 'python/canonical_coordinates_mod.f90.i', missing and no known rule to make it
make: *** [Makefile:71: build-deterministic] Error 1

@krystophny krystophny force-pushed the dep-audit/decompose-neo-core branch from 1a4bba3 to ef290f8 Compare May 15, 2026 19:58
@krystophny krystophny force-pushed the dep-audit/decompose-neo-core branch from ef290f8 to 309ad3f Compare June 5, 2026 20:43
@krystophny krystophny force-pushed the dep-audit/decompose-neo-core branch from 309ad3f to 9f732b8 Compare June 5, 2026 20:49
@krystophny krystophny force-pushed the dep-audit/decompose-neo-core branch from 9f732b8 to 7a10015 Compare June 5, 2026 23:22
@krystophny krystophny added tier/T4 parallel GPU dependency security build size/XS review size up to 10 changed lines labels Jun 5, 2026
Required by itpplasma/libneo#275 which moved VMEC support files
into a dedicated sub-target.
@krystophny krystophny force-pushed the dep-audit/decompose-neo-core branch from 7a10015 to 06b7f71 Compare June 5, 2026 23:37
@krystophny krystophny marked this pull request as ready for review June 6, 2026 12:41
@krystophny krystophny merged commit 7fa6280 into main Jun 6, 2026
9 of 10 checks passed
@krystophny krystophny deleted the dep-audit/decompose-neo-core branch June 6, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS review size up to 10 changed lines tier/T4 parallel GPU dependency security build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant