Improve readme and usability#154
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #154 +/- ##
=============================================
+ Coverage 93.71% 93.72% +<.01%
- Complexity 957 958 +1
=============================================
Files 105 105
Lines 2691 2695 +4
Branches 225 225
=============================================
+ Hits 2522 2526 +4
Misses 113 113
Partials 56 56
Continue to review full report at Codecov.
|
kaklakariada
changed the title
redcatbear
requested changes
Jul 1, 2018
redcatbear
left a comment
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
One improvement requested.
| } | ||
| } | ||
| throw new IllegalArgumentException("Unknown report format \"" + format + "\""); | ||
| final String availableValues = Arrays.stream(values()) // |
Collaborator
There was a problem hiding this comment.
Using a stream here is a bit much. Please use Java 8 String.join() instead.
Contributor
Author
There was a problem hiding this comment.
This only works for strings, not for enums. We need to keep this unless you want to change the input parameter from the short format (plain) to the enum value (PLAIN_TEXT)
redcatbear
approved these changes
Jul 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.