Configure finest log level for tests to improve code coverage for log…#155
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #155 +/- ##
============================================
+ Coverage 93.72% 93.93% +0.2%
- Complexity 958 981 +23
============================================
Files 105 105
Lines 2695 2704 +9
Branches 225 226 +1
============================================
+ Hits 2526 2540 +14
+ Misses 113 108 -5
Partials 56 56
Continue to review full report at Codecov.
|
kaklakariada
added a commit
that referenced
this pull request
Jul 7, 2018
kaklakariada
added a commit
that referenced
this pull request
Jul 7, 2018
kaklakariada
added a commit
that referenced
this pull request
Jul 7, 2018
redcatbear
approved these changes
Jul 14, 2018
redcatbear
left a comment
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
Approved with editorial changes.
| import org.junit.rules.TestRule; | ||
|
|
||
| /** | ||
| * This junit {@link TestRule} sets a temporary log level and a |
| * This junit {@link TestRule} sets a temporary log level and a | ||
| * {@link NoOpLoggingHandler} during tests and restores the original state after | ||
| * the test. This allows you to run the tests with all log messages but without | ||
| * the overhead of spamming the log. |
| @Override | ||
| public void publish(final LogRecord record) | ||
| { | ||
| // empty |
Collaborator
There was a problem hiding this comment.
"left empty on purpose".
| # #L% | ||
| ### | ||
| handlers = java.util.logging.ConsoleHandler | ||
| handlers = java.util.logging.ConsoleHandler org.itsallcode.openfasttrace.testutil.log.NoOpLoggingHandler |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… messages