Story/145 tags filter removes too many items#160
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
=============================================
+ Coverage 93.72% 93.77% +0.05%
- Complexity 958 988 +30
=============================================
Files 105 105
Lines 2695 2717 +22
Branches 225 231 +6
=============================================
+ Hits 2526 2548 +22
+ Misses 113 111 -2
- Partials 56 58 +2
Continue to review full report at Codecov.
|
Task-Url: #145
| @Test | ||
| public void testWithoutFilter() | ||
| { | ||
| this.exit.checkAssertionAfterwards(new Assertion() |
There was a problem hiding this comment.
Is it possible to use a lambda expression here? Then ITestCliWithFilter. should not be necessary.
If lambdas are not possible as a parameter: extract a method that accepts a lambda.
There was a problem hiding this comment.
Fixed: with pleasure. :-)
| public void testSetWantedTagsIncludingNone() | ||
| { | ||
| final String value = "_,client,server"; | ||
| assertThat(BEFORE_SETTER, this.arguments.getWantedTags(), emptyIterable()); |
There was a problem hiding this comment.
You could move this to the setup method.
There was a problem hiding this comment.
Improved by moving to separate test.
|
|
||
| protected void writeTextFile(final File file, final String content) throws IOException | ||
| { | ||
| final PrintWriter writer = new PrintWriter(file); |
There was a problem hiding this comment.
Is it possible to specify the encoding for the print writer? Else the encoding might depend on the platform.
2 participants
No description provided.