Feature/#165 file and line number in report by redcatbear · Pull Request #172 · itsallcode/openfasttrace

redcatbear · 2018-09-16T11:15:34Z

…d links.

kaklakariada · 2018-09-16T12:28:40Z

    {
-        this.reportService.reportTraceToPath(trace, output, format, this.verbosity, this.newline);
+        this.reportService.reportTraceToPath(trace, output, format, this.verbosity, this.newline,
+                this.showOrigin);


This argument list gets longer and longer. Maybe introduce a parameter object?

codecov · 2018-09-29T10:21:54Z

Codecov Report

Merging #172 into develop will increase coverage by 0.12%.
The diff coverage is 94.23%.

@@              Coverage Diff              @@
##             develop     #172      +/-   ##
=============================================
+ Coverage      94.31%   94.44%   +0.12%     
- Complexity      1004     1045      +41     
=============================================
  Files            106      108       +2     
  Lines           2745     2879     +134     
  Branches         231      243      +12     
=============================================
+ Hits            2589     2719     +130     
- Misses            98      103       +5     
+ Partials          58       57       -1

Impacted Files	Coverage Δ	Complexity Δ
...sallcode/openfasttrace/report/html/HtmlReport.java	`95.45% <ø> (ø)`	`5 <0> (ø)`	⬇️
...llcode/openfasttrace/exporter/ExporterFactory.java	`80.95% <ø> (ø)`	`12 <0> (ø)`	⬇️
...llcode/openfasttrace/importer/ImporterContext.java	`100% <100%> (ø)`	`4 <1> (ø)`	⬇️
...org/itsallcode/openfasttrace/cli/CliArguments.java	`93.1% <100%> (+0.65%)`	`33 <3> (+3)`	⬆️
...ode/openfasttrace/cli/commands/ConvertCommand.java	`100% <100%> (ø)`	`4 <3> (ø)`	⬇️
...ttrace/report/view/html/HtmlSpecificationItem.java	`94.52% <100%> (+2.85%)`	`35 <4> (+8)`	⬆️
...llcode/openfasttrace/exporter/ExporterService.java	`100% <100%> (ø)`	`3 <1> (ø)`	⬇️
...rc/main/java/org/itsallcode/openfasttrace/Oft.java	`100% <100%> (ø)`	`1 <1> (?)`
...llcode/openfasttrace/importer/ImporterService.java	`100% <100%> (ø)`	`4 <1> (-1)`	⬇️
...de/openfasttrace/cli/commands/AbstractCommand.java	`76.66% <100%> (+5.83%)`	`8 <1> (+1)`	⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eed764...d30c90b. Read the comment docs.

…ain.

…sion to 2.0.0.

redcatbear · 2018-10-10T19:42:13Z

@kaklakariada: implemented your change. Reworked the API in the course. Updated samples in the user giude.

Please review again.

kaklakariada

Merge conflicts fixed.

kaklakariada · 2018-10-13T10:09:10Z

+
+    protected List<SpecificationItem> importItems()
+    {
+        this.oft.addInputs(this.toPaths(this.arguments.getInputs()));


It would be possible to add the inputs to the ImportSettings class?

kaklakariada · 2018-10-13T10:10:52Z

+
+public class OftRunner implements Oft
+{
+    private final List<Path> inputs = new ArrayList<>();


Moving inputs to the ImportSettings would make this class stateless

kaklakariada · 2018-10-13T10:14:22Z

+import org.junit.Test;
+
+/**
+ * This class implements a parameter object to control the settings of OFT's


Comment does not fit to class (only mentioned once)

Removed from test.

# Conflicts: # pom.xml

redcatbear · 2018-10-13T13:16:47Z

@kaklakariada, please check again.

kaklakariada · 2018-10-13T13:50:20Z

+         */
+        public Builder addInputs(final Path... inputs)
+        {
+            for (final Path input : inputs)


You could do: this.addInputs(asList(inputs));

That would add another Import and creates an intermediate ArrayList so I consider this solution better here.

redcatbear added 2 commits September 14, 2018 19:52

#165: Updated requirements and design.

2e8b922

#165: Origin location now rendered correctly in specification item an…

ab62f41

…d links.

redcatbear requested a review from kaklakariada September 16, 2018 11:15

kaklakariada requested changes Sep 17, 2018

View reviewed changes

#165: Introduced parameter object for report settings.

8c22001

redcatbear added 5 commits October 7, 2018 19:19

#165: Refactoring to the point where Report unit tests are running ag…

ef99a2f

…ain.

#165: Commit before removing modes.

1e66c59

#165: Refactoring complete. All tests green.

a16113c

#165: Added missing license headers.

06d1476

#165: Unified builder for settings, updated user guide and raised ver…

680ffe0

…sion to 2.0.0.

kaklakariada requested changes Oct 13, 2018

View reviewed changes

kaklakariada and others added 3 commits October 13, 2018 12:22

Merge branch 'develop' into feature/#165_File_and_line_number_in_report

b1875e8

# Conflicts: # pom.xml

#165: OftRunner is now stateless.

cc8bdbe

#165: Removed erroneous comment.

d30c90b

kaklakariada approved these changes Oct 13, 2018

View reviewed changes

redcatbear merged commit 2bc48e7 into develop Oct 13, 2018

redcatbear deleted the feature/#165_File_and_line_number_in_report branch October 13, 2018 14:16

Uh oh!

Conversation

redcatbear commented Sep 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

redcatbear commented Oct 10, 2018

Uh oh!

kaklakariada left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

redcatbear commented Oct 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Sep 29, 2018 •

edited

Loading

kaklakariada left a comment •

edited

Loading