Skip to content

Create safe diagnostic records for failed reviews - #68

Merged
itsjling merged 2 commits into
mainfrom
codex/issue-035-observability
Jul 31, 2026
Merged

Create safe diagnostic records for failed reviews#68
itsjling merged 2 commits into
mainfrom
codex/issue-035-observability

Conversation

@itsjling

@itsjling itsjling commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Closes #35

Summary

  • add opt-in failed-run records with bounded IDs, versions, timings, byte counts, and exit state
  • omit prompts, patches, model output, paths, credentials, and environment values from the record
  • print a record or write one private JSON file, and keep that file out of the reviewed diff
  • cover agent, snapshot, publish, and serve failures with redaction tests

Stack

This PR must wait for both blockers.

Verification

  • npm ci
  • npm run lint
  • npm test — 91 passed
  • npm run docs:check
  • npm run docs:build
  • npm run fallow:audit -- --changed-since origin/codex/issue-034-cache-concurrency
  • npm pack --ignore-scripts --dry-run --json — confirms scripts/support-record.mjs ships

Stack

  1. Keep review notes outside target repos #43
  2. Make cached review state bounded and concurrency-safe #65
  3. Create safe diagnostic records for failed reviews #68 👈 current

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bed56904ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/present.mjs Outdated
Comment thread scripts/present.mjs Outdated
Comment thread scripts/present.mjs Outdated
@itsjling
itsjling force-pushed the codex/issue-035-observability branch from bed5690 to 1d53c61 Compare July 30, 2026 18:12
@itsjling

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d53c61ecf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/support-record.mjs
Comment thread scripts/generate-summaries.mjs Outdated
@itsjling
itsjling force-pushed the codex/issue-035-observability branch from 1d53c61 to ac8267d Compare July 30, 2026 18:37
@itsjling
itsjling force-pushed the codex/issue-034-cache-concurrency branch 2 times, most recently from c15bf01 to 61ecce8 Compare July 30, 2026 18:53
@itsjling
itsjling force-pushed the codex/issue-035-observability branch from ac8267d to d9ff1f8 Compare July 30, 2026 19:05
@itsjling
itsjling changed the base branch from codex/issue-034-cache-concurrency to main July 31, 2026 04:15
# Conflicts:
#	docs/content/cli.mdx
#	scripts/cli-args.mjs
#	scripts/generate-summaries.mjs
#	scripts/present.mjs
#	tests/present-help.test.mjs
@itsjling
itsjling merged commit 0e1ec6e into main Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create safe diagnostic records for failed reviews

1 participant