docs: mark option-like skill name plan as done - #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c2978ffb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Plan | Title | Priority | Effort | Depends on | Status | | ||
| | -------------------------------------------------- | ------------------------------------------------------- | -------: | -----: | ---------- | ------ | | ||
| | [001](001-reject-option-like-skill-names.md) | Reject option-like skill names before invoking `skills` | P1 | S | — | TODO | | ||
| | [001](001-reject-option-like-skill-names.md) | Reject option-like skill names before invoking `skills` | P1 | S | — | DONE | |
There was a problem hiding this comment.
This commit only changes the status row, while the required implementation is absent: normalizeInstallName has no safe-name assertion, discovery and catalog validation still accept dash-prefixed names, and applyCatalogInstall still forwards each raw entry.skill after --skill. Because this index instructs executors to follow plan statuses, marking Plan 001 DONE can cause its P1 security fix and regression tests to be skipped while the documented option-injection path remains reachable.
Useful? React with 👍 / 👎.
1 participant
Summary
DONEin the plans index.Testing