feat: icon composer file type#73
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the macOS app icon setup from an Asset Catalog (AppIcon.appiconset) to Xcode’s Icon Composer folder type (.icon), and introduces a string catalog (.xcstrings) for localized UI strings.
Changes:
- Add
AppIcon.icon(Icon Composer) and wire it into the Xcode project resources. - Add
Localizable.xcstringsstring catalog with many localized strings. - Remove the previous
Assets.xcassetsapp icon + accent color definitions from the repo/project.
Reviewed changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Front Row/Resources/Localizable.xcstrings | Adds a string catalog for localized UI strings (but currently contains duplicate keys + one typo). |
| Front Row/Resources/AppIcon.icon/icon.json | Defines the new Icon Composer app icon using an embedded PNG layer. |
| Front Row/Assets.xcassets/Contents.json | Removes the old asset catalog root metadata (catalog is being retired). |
| Front Row/Assets.xcassets/AppIcon.appiconset/Contents.json | Removes the old app icon asset catalog definition. |
| Front Row/Assets.xcassets/AccentColor.colorset/Contents.json | Removes the old global accent color asset definition. |
| Front Row.xcodeproj/project.pbxproj | Removes Assets.xcassets from the project and adds AppIcon.icon under Resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itsjoshpark
force-pushed
the
feat/icon-composer
branch
from
July 18, 2026 22:34
663e1fc to
74a5ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.