test(receipts): keep generated keys inside the test's tmp_path - #5
Merged
Conversation
The waiver path generates at `counterparty_key_default()`, which resolves under `$BONSAI_NOTARY_HOME` — so exercising it minted a live secp256k1 key in the developer's own key directory. Harmless once, wrong as a habit, and it makes the test's result depend on what happens to be there already. The fixture points BONSAI_NOTARY_HOME at tmp_path for every test in the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught on the first real run of #4: the waiver path generates at
counterparty_key_default(), under$BONSAI_NOTARY_HOME— so exercising it minted a live secp256k1 key in the developer's own key directory.Harmless once; wrong as a habit. A test that writes outside its tmp_path is also a test whose result depends on what is already there. An autouse fixture points
BONSAI_NOTARY_HOMEat tmp_path for the module.21 passed, and the real key directory stays empty.