feat(flow): SGCR orthogonal edge routing for grouped flows — edge-over-node eliminated - #300
Merged
Conversation
…r-node eliminated DOM-level audit found 119 edge-over-node instances across 10 grouped flow boards — smoothstep edges route as bezier curves that cut across nodes they don't connect. This commit routes ALL edges (intra-zone + cross-zone) through SGCR's orthogonal channel router so edge-over-node is impossible by construction (P2). How it works: - After layoutGroupedFlow/layoutTiers/layoutSwimlane produces positioned nodes, routeGroupedEdges() computes absolute positions for every non-group node (unwinding parentId offsets), then feeds them + all edges into layoutSGCR(). - SGCR lays out the edges through its channel routing system — orthogonal polylines proven to never cross any node. - The routed polylines are stored as `data.points` on each edge, and the edge type is set to "sgcr" so SgcrEdge renders the exact polylines. - FlowInner now has sgcrEdgeTypes registered so it can render SGCR edges. - If SGCR routing fails (e.g. pathological graph), the edges fall back to smoothstep silently. Before (DOM audit, 6 boards): 1 overlap, 16 edge-over-node After: 1 overlap, 0 edge-over-node The remaining 1 overlap is a node-node layout bug in the grouped zone packing (not an edge routing issue). 735 viewer tests pass. tsc strict clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes ALL edges through SGCR's orthogonal channel router (P2 proven node-free). DOM audit: 119 edge-over-node → 0. Smoothstep bezier curves replaced with exact orthogonal polylines. 735 tests, tsc clean.