Skip to content

Conversation

@lmichel
Copy link
Collaborator

@lmichel lmichel commented Apr 18, 2025

  • New datatype (Epoch(representation, value) for the timestamps
  • No more PhotometricProperty abstract class

@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025

The update of the 2 diagrams sounds good me.

@loumir loumir self-requested a review April 22, 2025 09:32
@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025

in the documentation generated for EPOCH type , the description strings are missing .

<dataType>
     <vodml-id>Epoch</vodml-id>
     <name>Epoch</name>
     <description>
           TODO : Missing description : please, update your UML model asap.   etc.... 

@lmichel
Copy link
Collaborator Author

lmichel commented Apr 22, 2025

The VODML with descriptions is in vo-dml.
Description elements are edited in specific files

/desc.mango.vo-dml.xml

@loumir
Copy link
Collaborator

loumir commented Apr 22, 2025

found on typo in /desc.mango.vo-dml.xml
on line 114 : "usually an instance of \texttt{mango:EpcohPosition}."
sourd be "usually an instance of \texttt{mango:EpochPosition}."

@lmichel
Copy link
Collaborator Author

lmichel commented May 4, 2025

The PR branch has been updated taking the comment into account and Epoch data type has been renamed as DateTime and EpochPosition.epoch renamed as EpochPosition.obsDate

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

difficult to interpret the change here . I suppose it is OK .

Datatype --> Data type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear in this diagram wether DateTime (with representation) is a class ( greenBlue) or a type (light yellow)

loumir added 2 commits May 5, 2025 12:42
ambiguous ' Second date ' ....
Copy link
Collaborator

@loumir loumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes . This clarifies Time related information in the EpochPosition Class as presented in issue #85

@lmichel lmichel merged commit 4db22bb into ivoa-std:wd-v1.0 May 13, 2025
1 check passed
@lmichel lmichel deleted the TimeInstant/Epoch branch June 20, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants