fix: enforce consistent evaluation order in emit - #526
Merged
Conversation
Merged
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lis evaluates expressions left to right, but it was possible for the emitted Go to read an indexed receiver, computed callee, slice bound, or assignment target after a sibling expession had already changed a value it depended on, leading to the wrong slot, fn or ptr being used at runtime. Hence this PR pins those operands into a temp before the sibling runs, so eval order matches the source order.
For example:
Source order says
xss[i]is chosen whileiis still0, so the append targetsxss[0]andys[0]is10. Previously the emitted Go ranbump(&i)first, bumpingito1, so it appended toxss[1]and printed20. The fix capturesxss[i]into a temp beforebumpruns, so the receiver is locked in at the source-order moment.