Skip to content
This repository was archived by the owner on May 4, 2026. It is now read-only.
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/@expo/cli/src/utils/mergeGitIgnorePaths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ export function mergeGitIgnorePaths(
return null;
}

const targetGitIgnore = fs.readFileSync(targetGitIgnorePath).toString();
const sourceGitIgnore = fs.readFileSync(sourceGitIgnorePath).toString();
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
const targetGitIgnore = fs.readFileSync(targetGitIgnorePath, 'utf8');
const sourceGitIgnore = fs.readFileSync(sourceGitIgnorePath, 'utf8');
const merged = mergeGitIgnoreContents(targetGitIgnore, sourceGitIgnore);
// Only rewrite the file if it was modified.
if (merged.contents) {
Expand Down
6 changes: 4 additions & 2 deletions packages/@expo/config-plugins/src/android/Package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ export async function renameJniOnDiskForType({
filesToUpdate.forEach((filepath: string) => {
try {
if (fs.lstatSync(filepath).isFile() && ['.h', '.cpp'].includes(path.extname(filepath))) {
let contents = fs.readFileSync(filepath).toString();
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
let contents = fs.readFileSync(filepath, 'utf8');
contents = contents.replace(
new RegExp(transformJavaClassDescriptor(currentPackageName).replace(/\//g, '\\/'), 'g'),
transformJavaClassDescriptor(packageName)
Expand Down Expand Up @@ -207,7 +208,8 @@ export async function renamePackageOnDiskForType({
filesToUpdate.forEach((filepath: string) => {
try {
if (fs.lstatSync(filepath).isFile()) {
let contents = fs.readFileSync(filepath).toString();
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
let contents = fs.readFileSync(filepath, 'utf8');
if (path.extname(filepath) === '.kt') {
contents = replacePackageName(contents, currentPackageName, kotlinSanitizedPackageName);
} else {
Expand Down
12 changes: 8 additions & 4 deletions packages/expo-brownfield/plugin/src/common/filesystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,16 @@ const maybeReadOverwrittenTemplate = (template: string, platform?: PlatformStrin
try {
accessSync(path.join(process.cwd(), '.brownfield-templates'));
if (existsSync(path.join(process.cwd(), '.brownfield-templates', template))) {
return readFileSync(path.join(process.cwd(), '.brownfield-templates', template)).toString();
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
return readFileSync(path.join(process.cwd(), '.brownfield-templates', template), 'utf8');
}

if (existsSync(path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template))) {
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
return readFileSync(
path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template)
).toString();
path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template),
'utf8'
);
}
// eslint-disable-next-line no-empty
} catch {}
Expand All @@ -55,7 +58,8 @@ const readTemplate = (template: string, platform?: PlatformString): string => {
throw new Error(`Template ${template} doesn't exist at ${templatePath}`);
}

return readFileSync(templatePath).toString();
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
return readFileSync(templatePath, 'utf8');
};

const createFileFromTemplateInternal = (
Expand Down
3 changes: 2 additions & 1 deletion packages/pod-install/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ async function runAsync(maybeProjectDirectory?: string): Promise<void> {
process.exit(1);
}

const jsonData = JSON.parse(readFileSync(packageJsonPath).toString());
// Optimization: pass 'utf8' directly to avoid intermediate buffer allocation
const jsonData = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
const hasExpoPackage = jsonData.dependencies?.hasOwnProperty('expo');

if (hasExpoPackage) {
Expand Down