fix(android): serve web manifest locally for bubblewrap project generation - #146
Merged
Merged
Conversation
bubblewrap also fetches webManifestUrl during project generation. app.fuzefront.com/manifest.webmanifest returns HTML (404) which bubblewrap can't parse as JSON. - Add frontend/public/manifest.webmanifest (static copy, same content as what Vite PWA plugin generates in dist/) - Patch webManifestUrl to http://localhost:8080/manifest.webmanifest alongside the icon URL patches already in place Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APK build run #4 revealed that
bubblewrap updatealso fetcheswebManifestUrl(https://app.fuzefront.com/manifest.webmanifest) during project generation — not just the icons. Since the production URL isn't live yet, it gets back an HTML 404 page, causingcli ERROR Unexpected token '<', "<!doctype "... is not valid JSON.frontend/public/manifest.webmanifest— a static copy matching what the Vite PWA plugin generates indist/. This file will also be served by the live app once deployed.webManifestUrltohttp://localhost:8080/manifest.webmanifestin the scaffold step, alongside the existing icon URL patches.frontend/public/manifest.webmanifestto the workflowpathstrigger so future manifest changes rebuild the APK.What changed
frontend/public/manifest.webmanifest— new static web app manifest (same JSON asdist/manifest.webmanifest).github/workflows/build-android-apk.yml— patchwebManifestUrlto localhost + add path triggerTest plan
bubblewrap updatecompletes (all 3 icon GETs + 1 manifest GET return 200 from localhost)bubblewrap buildproduces a signed APKfuzefront-android-vNuploadedandroid-vNcreatedGenerated by Claude Code