fix(android): re-patch signing passwords before bubblewrap build - #148
Merged
Conversation
bubblewrap update clears signingKey.storePassword and keyPassword from twa-manifest.json when it regenerates the Android project, so bubblewrap build subsequently prompts interactively (exit 130, no TTY). Re-apply the passwords from secrets immediately before build. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run #5 revealed the next layer:
bubblewrap updateclearssigningKey.storePasswordandkeyPasswordfromtwa-manifest.jsonwhen it regenerates the Android project. By the timebubblewrap buildruns, the password fields are empty so it falls back to an interactive TTY prompt — which fails with exit 130 (no TTY in CI).Fix: re-apply both passwords from the GitHub Secrets immediately before calling
bubblewrap build, using the same node patch already used in the scaffold step.Progress so far
bubblewrap inithung on JDK prompt~/.bubblewrap/config.json+ Android SDK actionInvalid URLfrom local path passed as manifest URLbubblewrap updateapp.fuzefront.comfrontend/public/manifest.webmanifest, patchwebManifestUrlbubblewrap buildprompts for keystore password (exit 130)Test plan
fuzefront-android-v6uploadedandroid-v6createdGenerated by Claude Code