fix(ci): restore Trivy SARIF upload to harden-gate with category:trivy#216
Merged
Merged
Conversation
…y-scan with category:trivy Add detect-pr step so SARIF uploads to the correct PR ref/sha, and add pull-requests: read permission required by the gh api lookup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session-Id: 4828017f-ed5a-491d-91fa-edc6d6648789
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // that failure was previously masked because the permit-pdp service | ||
| // container aborted the CI job before any test ran. | ||
| // Hash passwords so the login endpoint can verify them in API tests. | ||
| const ownerHash = await bcrypt.hash('test-password', 10) |
| // container aborted the CI job before any test ran. | ||
| // Hash passwords so the login endpoint can verify them in API tests. | ||
| const ownerHash = await bcrypt.hash('test-password', 10) | ||
| const adminHash = await bcrypt.hash('admin-password', 10) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upload-sarifstep ingate-dependency-scanthat was removed in commit8205093(incorrectly believed to cause a race condition)detect-prstep so SARIF uploads target the correct PR ref/sha onpush/workflow_dispatcheventspull-requests: readpermission required by thegh apilookupignore-unfixed: trueandtrivyignores: '.trivyignore'to suppress noiseWhy
Master's Code Scanning baseline requires two Trivy configurations:
ci.yml:security-scan(no category) — already satisfiedharden-gate.ymlwithcategory: trivy— was broken because the upload step was removedThis restores configuration 2, which unblocks the "Trivy" Code Scanning check on PRs.
Test plan
harden-gate.yml:gate-dependency-scanon this PRharden-gate.yml:trivyconfiguration satisfied (no "1 configuration not found" error)🤖 Generated with Claude Code