feat(security): password reset flow (request/confirm + session revocation) - #290
Merged
Conversation
… + reset notification [skip ci] Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com> Claude-Session-Id: cf830721-b1ef-4fe0-a024-035ad280dcf7
…tion) [skip ci] Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com> Claude-Session-Id: cf830721-b1ef-4fe0-a024-035ad280dcf7
…ed this) Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com> Claude-Session-Id: cf830721-b1ef-4fe0-a024-035ad280dcf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
POST /session/password/reset-requestand/session/password/reset-confirm— in the frozen contract (#273) but 404 in production; never implemented.tscandjesthave never run against this. The authoring agent's isolated-cachenpm installtimed out twice, then plan mode froze it. 19 tests exist and have executed zero times. CI is the gate here; do not read this PR as a claim that it works.Design
013_create_password_resets).authenticateTokenenforce thesessionstable, deleting those rows genuinely logs the attacker out — a reset that left old sessions alive would be theatre.?email=is a filter, not an exact match — resetting the wrong account would be unacceptable.Three decisions worth scrutinising
emailVerificationEnabled()), rather than stranding the user.hold— deploy-on-push; ruleset requires 1 approving review.Co-Authored-By: Claude