fix(frontend): stabilize WorkspaceProvisioningGate provisioning-spinner test - #345
Merged
Merged
Conversation
…er test
The "shows the provisioning spinner when no personal org exists yet" test
waited for role="status" and then synchronously asserted the provisioning
copy ("Creating your workspace…"). But the gate renders a spinner
(role="status") in BOTH its initial `checking` state (returning-user copy,
"Loading your workspace…") and its `provisioning` state. The waitFor was
satisfied by the initial `checking` render, so the synchronous getByText for
the provisioning copy fired before the async org check transitioned the gate
to `provisioning`, throwing a Testing-Library getElementError. This failed
"Lint & Test (18.x/20.x)" on every PR regardless of touched files.
Fix the race in the test (component behavior is correct and intentional):
wait for the provisioning-specific text instead of the ambiguous spinner
role, then assert the spinner/absence-of-app-content.
Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com>
Claude-Session-Id: a560dedc-819a-4776-bee0-3f8703ae66fe
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
The "OIDC plumbing (local user, no Google)" job failed on master because the browser specs drifted from the reworked login UI (migrated to FuzeFront's Security API). The 7 API-level tests pass; the 3 browser tests asserted removed behaviour: - Native credentials form now posts POST /api/v1/security/session (authAPI.login), not the old /api/auth/oidc/password. Point the waitForResponse at the current endpoint. - The dedicated "Sign in with Authentik" redirect button was removed; the only redirect entry point is the Google button (-> /api/v1/security/social/google/start). In no-Google mode (empty GOOGLE_CLIENT_ID) a full interactive Authentik round-trip is unreachable, so the old full-OIDC-via-button test can't pass. Replace it with one asserting the button initiates the server-brokered social start. The real server-side OIDC token exchange against Authentik is still covered end-to-end by the passing API-level password test, and interactive social is covered by the separate tunnel-mode Google e2e. Remove the now-unused Authentik login-form helper. - Error-display test hit a Playwright strict-mode violation (the error surfaces in 2 elements); scope the locator to .first(). Test-only change; no app code touched (no regression found — the app behaviour the specs now assert is the current, intended behaviour). Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com> Claude-Session-Id: a560dedc-819a-4776-bee0-3f8703ae66fe
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
frontend/src/components/__tests__/WorkspaceProvisioningGate.test.tsx— the test "shows the provisioning spinner when no personal org exists yet" — fails the Lint & Test (18.x/20.x) CI job on every PR, including PRs that touch no frontend code (observed inherited frommasteron the frames-only PR #335).Root cause — a test timing race, not a component bug
WorkspaceProvisioningGatedeliberately has two loading states, both rendered viaProvisioningCard state="loading"(which always emitsrole="status"):checkingprovisioningThe test did:
role="status"is present in the initialcheckingrender, sowaitForresolved immediately — before the asyncgetOrganizations()check resolved and transitioned the gate toprovisioning. The synchronousgetByText('Creating your workspace…')then ran against thecheckingDOM ("Loading your workspace…") and threw a Testing-LibrarygetElementError.Fix
Component behavior is correct and intentional (the checking/provisioning copy split is deliberate — it stops returning users seeing "Creating your workspace"). The fix is in the test: wait for the provisioning-specific text to confirm the state transition, rather than the ambiguous spinner role shared by both states.
Verification
Deferring to CI (Lint & Test 18.x/20.x) as the authoritative check — a crippled local npm network + Windows
node_modulescorruption made a clean localvitestrun infeasible in this environment. The change is test-only (+6/-2), scoped to the single racing assertion; no source or other tests are touched.Separate from the auth-experience / signup work in flight.
🤖 Generated with Claude Code