Cache Node version queries

[j178]

Summary

• cache Node version queries by canonical executable path

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.61%. Comparing base (d53c399) to head (d7703d9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   93.61%   93.61%   -0.01%     
==========================================
  Files         131      131              
  Lines       28409    28422      +13     
==========================================
+ Hits        26594    26606      +12     
- Misses       1815     1816       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR improves language toolchain discovery performance by caching Node (and Python) version/info queries keyed by the canonical executable path, so repeated health checks and PATH discovery reuse prior results within a single prek run.

Changes:

• Add a global Node version cache and route Node health checks/system discovery through a cached query path.
• Store NodeVersion behind Arc in NodeResult so cached results can be shared cheaply.
• Simplify Python info error handling while adding a cached Python-info query keyed by canonical interpreter path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/prek/src/languages/python/python.rs	Adds a canonical-path-keyed cache for Python interpreter info and removes an obsolete error variant/state.
crates/prek/src/languages/node/node.rs	Switches Node health checks to use cached Node version queries.
crates/prek/src/languages/node/installer.rs	Implements canonical-path-keyed Node version caching and shares versions via Arc<NodeVersion>.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[prek-ci-bot]

📦 Cargo Bloat Comparison

Binary size change: +0.00% (29.6 MiB → 29.6 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  73.4KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  56.1KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  48.0KiB              prek prek::run::{closure#0}
 0.1%   0.3%  38.9KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.0KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.7KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.2KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.3KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.2KiB              prek prek::cli::update::update::{closure#0}
42.3%  88.2%  12.5MiB                   And 26288 smaller methods. Use -n N to show more.
47.9% 100.0%  14.2MiB                   .text section size, the file size is 29.6MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  84.6KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  56.1KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  48.1KiB              prek prek::run::{closure#0}
 0.1%   0.3%  39.1KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  32.8KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  28.8KiB              prek <prek::languages::node::installer::NodeInstaller>::install::{closure#0}
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.1KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.7KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.2KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.3KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
42.3%  88.2%  12.5MiB                   And 26301 smaller methods. Use -n N to show more.
48.0% 100.0%  14.2MiB                   .text section size, the file size is 29.6MiB

[prek-ci-bot]

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

• OS: Linux 6.17.0-1020-azure
• CPU: 4 cores
• prek version: prek 0.4.12+15 (cf0e399 2026-08-07)
• Rust version: rustc 1.97.1 (8bab26f4f 2026-07-14)
• Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.2 ± 0.1	2.1	2.8	1.00
prek-head --version	2.3 ± 0.1	2.1	2.5	1.03 ± 0.07

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	9.4 ± 0.8	8.9	14.9	1.02 ± 0.09
prek-head list	9.2 ± 0.3	8.9	10.6	1.00

prek validate-config .pre-commit-config.yaml

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base validate-config .pre-commit-config.yaml	3.1 ± 0.1	3.0	3.4	1.02 ± 0.03
prek-head validate-config .pre-commit-config.yaml	3.1 ± 0.1	3.0	3.2	1.00

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.4 ± 0.0	2.3	2.5	1.00 ± 0.03
prek-head sample-config	2.4 ± 0.1	2.3	2.6	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	36.5 ± 1.3	34.7	38.6	1.01 ± 0.05
prek-head run --all-files	36.2 ± 1.5	33.7	38.2	1.00

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	36.6 ± 1.1	34.6	38.5	1.00 ± 0.03
prek-head run --all-files	36.6 ± 0.7	35.5	37.9	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	36.9 ± 1.2	34.1	40.5	1.00
prek-head run --all-files	37.5 ± 1.7	34.8	45.0	1.02 ± 0.06

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	12.6 ± 0.5	11.9	13.8	1.02 ± 0.05
prek-head run trailing-whitespace --all-files	12.4 ± 0.3	11.8	13.2	1.00

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	10.8 ± 0.7	10.0	13.4	1.03 ± 0.08
prek-head run end-of-file-fixer --all-files	10.5 ± 0.5	9.7	11.8	1.00

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	7.6 ± 0.2	7.1	7.9	1.01 ± 0.06
prek-head run check-json --all-files	7.5 ± 0.4	6.7	8.8	1.00

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	7.4 ± 0.1	7.1	7.6	1.00 ± 0.02
prek-head run check-yaml --all-files	7.3 ± 0.1	7.1	7.7	1.00

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	7.4 ± 0.3	7.0	8.1	1.00 ± 0.05
prek-head run check-toml --all-files	7.4 ± 0.3	6.9	8.0	1.00

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	7.4 ± 0.5	7.0	9.1	1.00
prek-head run check-xml --all-files	7.6 ± 0.5	7.0	8.8	1.02 ± 0.10

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	10.6 ± 0.6	9.5	12.0	1.02 ± 0.07
prek-head run detect-private-key --all-files	10.4 ± 0.4	9.4	11.2	1.00

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	12.4 ± 0.7	11.4	14.3	1.03 ± 0.08
prek-head run fix-byte-order-marker --all-files	12.1 ± 0.6	11.3	13.5	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.4 ± 0.1	4.3	4.4	1.00
prek-head install-hooks	4.4 ± 0.1	4.3	4.4	1.01 ± 0.02

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.5 ± 0.0	4.4	4.5	1.01 ± 0.02
prek-head install-hooks	4.4 ± 0.1	4.3	4.5	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	23.3 ± 0.4	22.4	23.9	1.00
prek-head run	23.7 ± 0.4	23.2	24.6	1.02 ± 0.02

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	5.1 ± 0.1	4.9	5.2	1.00 ± 0.02
prek-head run --files '*.json'	5.0 ± 0.1	5.0	5.1	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	6.8 ± 0.1	6.5	7.0	1.01 ± 0.02
prek-head run --dry-run --all-files	6.7 ± 0.1	6.6	6.8	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	8.0 ± 0.2	7.8	8.3	1.00
prek-head run check-hooks-apply --all-files	8.2 ± 0.2	7.9	8.6	1.02 ± 0.03

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	8.2 ± 0.6	7.8	10.1	1.04 ± 0.07
prek-head run check-useless-excludes --all-files	7.8 ± 0.1	7.7	7.9	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	6.9 ± 0.1	6.7	7.1	1.00 ± 0.02
prek-head run identity --all-files	6.9 ± 0.1	6.7	7.0	1.00