Skip to content

Remove 32-bit support#2685

Merged
riccardobl merged 4 commits intojMonkeyEngine:masterfrom
8Keep:deprecate-32-bit
May 1, 2026
Merged

Remove 32-bit support#2685
riccardobl merged 4 commits intojMonkeyEngine:masterfrom
8Keep:deprecate-32-bit

Conversation

@8Keep
Copy link
Copy Markdown
Contributor

@8Keep 8Keep commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for 32-bit Windows and 32-bit macOS across the engine. Key changes include updating platform detection logic to throw exceptions for 32-bit systems, removing 32-bit enum constants from the Platform class, and cleaning up native library loading and build dependencies. Feedback suggests refactoring the platform detection logic in JmeSystemDelegate.java to reduce redundant bitness checks in the Windows and macOS blocks.

Comment thread jme3-core/src/main/java/com/jme3/system/JmeSystemDelegate.java Outdated
Comment thread jme3-core/src/main/java/com/jme3/system/JmeSystemDelegate.java Outdated
@8Keep 8Keep changed the title Remove Windows and macOS 32-bit support Remove 32-bit x86 support Apr 7, 2026
@8Keep 8Keep force-pushed the deprecate-32-bit branch from 6e65c05 to 7a98786 Compare April 7, 2026 02:44
@8Keep 8Keep marked this pull request as ready for review April 7, 2026 03:13
@riccardobl
Copy link
Copy Markdown
Member

Nice! Maybe we should drop MacOS Power PC too?

@8Keep 8Keep force-pushed the deprecate-32-bit branch 3 times, most recently from f1fc6cd to cd49eba Compare April 7, 2026 09:35
@8Keep
Copy link
Copy Markdown
Contributor Author

8Keep commented Apr 7, 2026

Done

@riccardobl riccardobl added Refactoring and Cleanup This PR is all about improving code quality and javadoc. buildscript An issue with the buildscript labels Apr 7, 2026
@yaRnMcDonuts yaRnMcDonuts added this to the v3.10.0 milestone Apr 7, 2026
@8Keep 8Keep force-pushed the deprecate-32-bit branch from cd49eba to 4ebe8bc Compare April 8, 2026 23:08
@riccardobl
Copy link
Copy Markdown
Member

riccardobl commented May 1, 2026

Thanks! I made some changes to this PR to also remove all the android 32 bit platforms, and linux arm32, and some small refactoring.

@gemini-code-assist please review

@riccardobl riccardobl changed the title Remove 32-bit x86 support Remove 32-bit support May 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes 32-bit architecture support across Android, iOS, and desktop platforms, refactoring the Platform enum and native library loading logic to focus on 64-bit systems. Feedback identifies a potential crash in JmeAndroidSystem due to the use of Build.SUPPORTED_ABIS on older Android versions and notes that 32-bit Linux ARM dependencies should be removed from the LWJGL3 build configuration to maintain consistency with the dropped support.

Comment thread jme3-android/src/main/java/com/jme3/system/android/JmeAndroidSystem.java Outdated
Comment thread jme3-lwjgl3/build.gradle
@riccardobl
Copy link
Copy Markdown
Member

@gemini-code-assist please review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for 32-bit architectures across the project, including updates to Gradle configurations, native library definitions, and system platform detection logic. The review identified a potential runtime crash in the Android platform initialization due to accessing Build.SUPPORTED_ABIS on older API levels, and suggested refinements to the is64Bit and isX86Architecture helper methods in JmeSystemDelegate to ensure consistent handling of 32-bit architectures like universal.

Comment thread jme3-android/src/main/java/com/jme3/system/android/JmeAndroidSystem.java Outdated
Comment thread jme3-core/src/main/java/com/jme3/system/JmeSystemDelegate.java
Comment thread jme3-core/src/main/java/com/jme3/system/JmeSystemDelegate.java
…ystem.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@riccardobl riccardobl merged commit a92bd18 into jMonkeyEngine:master May 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildscript An issue with the buildscript Refactoring and Cleanup This PR is all about improving code quality and javadoc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants