Remove 32-bit support#2685
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes support for 32-bit Windows and 32-bit macOS across the engine. Key changes include updating platform detection logic to throw exceptions for 32-bit systems, removing 32-bit enum constants from the Platform class, and cleaning up native library loading and build dependencies. Feedback suggests refactoring the platform detection logic in JmeSystemDelegate.java to reduce redundant bitness checks in the Windows and macOS blocks.
|
Nice! Maybe we should drop MacOS Power PC too? |
f1fc6cd to
cd49eba
Compare
|
Done |
|
Thanks! I made some changes to this PR to also remove all the android 32 bit platforms, and linux arm32, and some small refactoring. @gemini-code-assist please review |
There was a problem hiding this comment.
Code Review
This pull request removes 32-bit architecture support across Android, iOS, and desktop platforms, refactoring the Platform enum and native library loading logic to focus on 64-bit systems. Feedback identifies a potential crash in JmeAndroidSystem due to the use of Build.SUPPORTED_ABIS on older Android versions and notes that 32-bit Linux ARM dependencies should be removed from the LWJGL3 build configuration to maintain consistency with the dropped support.
|
@gemini-code-assist please review |
There was a problem hiding this comment.
Code Review
This pull request removes support for 32-bit architectures across the project, including updates to Gradle configurations, native library definitions, and system platform detection logic. The review identified a potential runtime crash in the Android platform initialization due to accessing Build.SUPPORTED_ABIS on older API levels, and suggested refinements to the is64Bit and isX86Architecture helper methods in JmeSystemDelegate to ensure consistent handling of 32-bit architectures like universal.
…ystem.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
#2588