feat(stdlib): add OptionShouldPing to control ResetSession ping behavior#2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1738 (comment)
In
pgx/v5, the stdlib driver (database/sql integration) pings the server duringConn.ResetSessionwhenever a connection is reused after being idle for >1s. This matches pgxpool’s defaultShouldPinglogic, but for some proxies (e.g. PgBouncer admin console) the PostgreSQL-- pingcommand is not supported and results in noisy log entries such as:Currently, stdlib users cannot disable this ping without setting
MaxIdleConns(0)(which forces every query to open a new connection, causing connect/close churn).This PR introduces an optional
OptionShouldPinghook for stdlib, mirroring the existingpgxpool.ShouldPingdesign: