Skip to content

Match Binance ladder normalized empty rollback - #199

Merged
jackhai9 merged 1 commit into
mainfrom
codex/fix-ladder-normalized-empty-rollback
Aug 27, 2026
Merged

Match Binance ladder normalized empty rollback#199
jackhai9 merged 1 commit into
mainfrom
codex/fix-ladder-normalized-empty-rollback

Conversation

@jackhai9

Copy link
Copy Markdown
Owner

Root cause

The ladder input reader normalizes controlled input values with normalizeDecimalString, which maps an empty input to null. The ladder recovery policy incorrectly allowed only the raw empty string, so it rejected the exact normalized rollback even when the input identity, form root, write budget, and provisional recovery contract were all valid. Raw CDP breakpoint evidence confirmed rollbackValue=null with recovery otherwise eligible.

Changes

  • match the ladder recovery policy to the exact normalized empty value (null)
  • use the production decimal normalizer/comparator in recovery tests
  • lock the normalized policy in source-regression tests
  • bump the userscript version to 2.7.138

Validation

  • npm test (371/371)
  • focused trade-form/source regression tests (78/78)
  • npm run build:binance-orderbook-trade
  • npm run check:binance-orderbook-trade
  • git diff --check
  • raw CDP closure-variable diagnosis
  • independent read-only root-cause and final-diff reviews

@jackhai9
jackhai9 merged commit fd54365 into main Aug 27, 2026
1 check passed
@jackhai9
jackhai9 deleted the codex/fix-ladder-normalized-empty-rollback branch August 27, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant