Skip to content

Add RootFS license/NOTICE candidate bundle#27

Merged
jacklv-coder merged 2 commits into
mainfrom
codex/rootfs-license-notice-candidates
Jul 26, 2026
Merged

Add RootFS license/NOTICE candidate bundle#27
jacklv-coder merged 2 commits into
mainfrom
codex/rootfs-license-notice-candidates

Conversation

@jacklv-coder

Copy link
Copy Markdown
Owner

Summary

  • add a checksum-bound external LICENSE/NOTICE candidate manifest for the 8 remaining RootFS source origins
  • add strict validation and an outside-repository atomic materializer/verifier for 21 reviewed evidence files, 8 remote payloads, and 46 supplemental aports files
  • integrate the candidate index into reproducible compliance outputs, CI, and bilingual release documentation

Candidate payloads remain outside Git. Engineering review approval, legal review, and redistribution approval remain false.

Validation

  • full Ruby/shell RootFS script suite
  • real external source-review + license-review candidate bundle verification
  • real HTTPS streaming download with pinned byte count and SHA-256
  • reproducible compliance generation/check from pinned v0.3.3 archive
  • swift test (139 tests, 1 expected skip, 0 failures)
  • pinned RootFS release-asset Swift test
  • bilingual documentation check and git diff --check
  • Codex CR after fixes: no actionable correctness findings

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aaf3618b18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +410 to +411
rescue ArgumentError, URI::InvalidURIError, SocketError, SystemCallError,
Timeout::Error, OpenSSL::SSL::SSLError => error

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle Net::HTTP connection errors before trying fallback URLs

When an HTTPS proxy rejects the CONNECT request or Net::HTTP encounters a protocol-level failure, Net::HTTP.start can raise Net::HTTPClientException/Net::HTTPFatalError, which this rescue list does not convert to BundleError. Consequently, fetch_remote_payload cannot record the failure and try the next pinned URL, and the top-level handler emits an uncaught stack trace instead of a controlled materialization error. This occurs, for example, with a proxy returning HTTP 403 during connection setup.

Useful? React with 👍 / 👎.

@jacklv-coder
jacklv-coder merged commit e81e05b into main Jul 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant