Refactor into modular server build pipeline#1
Merged
Conversation
jackson-asmith
commented
Apr 9, 2026
jackson-asmith
commented
Owner
- Replace monolithic scripts with staged, parameterized equivalents: base-setup, ad-join, satellite-register, ad-rejoin-cron
- Add deploy.sh entrypoint with per-stage skip flags
- Extract all hardcoded credentials and domain names into environment variables; document in config/env.example
- Convert krb5/sssd configs to envsubst templates
- Replace deprecated Spacewalk registration with Red Hat Satellite 6/7 support; auto-detects rhc vs katello-agent based on availability
- Add set -euo pipefail and ERR traps to all scripts
- Make all scripts idempotent
- Replace deprecated authconfig/ifconfig with authselect/ip
- Add GitHub Actions lint workflow (ShellCheck, visudo, template coverage)
- Update README to reflect pipeline structure
- Replace monolithic scripts with staged, parameterized equivalents: base-setup, ad-join, satellite-register, ad-rejoin-cron - Add deploy.sh entrypoint with per-stage skip flags - Extract all hardcoded credentials and domain names into environment variables; document in config/env.example - Convert krb5/sssd configs to envsubst templates - Replace deprecated Spacewalk registration with Red Hat Satellite 6/7 support; auto-detects rhc vs katello-agent based on availability - Add set -euo pipefail and ERR traps to all scripts - Make all scripts idempotent - Replace deprecated authconfig/ifconfig with authselect/ip - Add GitHub Actions lint workflow (ShellCheck, visudo, template coverage) - Update README to reflect pipeline structure
Owner
Author
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.