fix(boss): retry detached read once - #2224
Draft
shaomingbo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bossFetchonce when aGETevaluation fails withdetached_mid_commandPOST, because a detached mid-command write may already have completedRoot cause
The Browser Bridge correctly treats
detached_mid_commandas non-retryable at the genericPage.evaluatelayer because the command outcome is unknown. BOSSbossFetchknows whether its XHR is a read or a write, so it can safely replay a detachedGETwithout weakening the core write-safety boundary.An isolated BOSS search canary reached
bossFetchand failed withBoss API request failed: Detached while handling command.after navigation had succeeded. The trace reported no failed network requests. The patched adapter was not retried live because the canary authorization explicitly allowed no retry.Validation
GETsucceeds on one replayGETis propagated after exactly two evaluationsPOSTis propagated after one evaluationnpm run typechecknpm run buildgit diff --check